Changeset 159

Timestamp:

04/03/10 23:57:32 (5 months ago)

Author:

mbooth

Message:

Detect dangling PTR record problems and show icons when problems occur.

Location:

trunk/misc

Files:

• dns-o-matic.py (modified) (5 diffs)
• icons (added)
• icons/error.png (added)
• icons/info.png (added)
• icons/warning.png (added)

trunk/misc/dns-o-matic.py

@@ -82 +82 @@
                       'status'      : r.header['status'],
                       'subrecords'  : [],
+                      'problems'    : [],
                       }
             data.append(answer)
@@ -99 +100 @@
                   'status'      : r.header['status'],
                   'subrecords'  : [],
+                  'problems'    : [],
                   }
         data.append(answer)
@@ -130 +132 @@
 
 
-def FindValidLoops(data):
-    # do a depth-first search for request loops and mark these records as valid
-    num = 0
-    for result in data['results']:
-        new_num = FindValidLoops(result)
-        if new_num > num:
-            num = new_num
-    if not data['status']:
-        data['valid'] = True
-        return 2
-    else:
-        if num > 0:
-            data['valid'] = True
-            return num - 1
-        else:
-            data['valid'] = False
-            return 0
+#def FindValidLoops(data):
+#   # do a depth-first search for request loops and mark these records as valid
+#   num = 0
+#   for result in data['results']:
+#       new_num = FindValidLoops(result)
+#       if new_num > num:
+#           num = new_num
+#   if not data['status']:
+#       data['valid'] = True
+#       return 2
+#   else:
+#       if num > 0:
+#           data['valid'] = True
+#           return num - 1
+#       else:
+#           data['valid'] = False
+#           return 0
+
+
+def FindDanglingPointers(data):
+    for rec in data['subrecords']:
+        if rec['status'] == 'NXDOMAIN':
+            problem = {
+                       'icon':'error',
+                       'text':'Dangling pointer (PTR) record detected for %s!\n\n' % data['lookup_of'] + \
+                              'Perhaps it was left behind when the address (A) record for %s was deleted.' % data['resolves_to'],
+                       }
+            rec['problems'].append(problem)
 
 
@@ -176 +189 @@
     sys.stderr.write("\n")
 
-    # iterate through all addresses for which we have results
-#   for address in data['addresses']:
-#       for ns_result in address['results']:
-#           FindValidLoops(ns_result)
+    # detect dangling pointers
+    for address in data['addresses']:
+        for result in address['results']:
+            FindDanglingPointers(result)
     return data
 
@@ -186 +199 @@
     # display the record we're looking up
     if data['resolves_to'] != '':
-        print "    <p style='padding-left:%spx'><span class='record'>%s</span> resolves to: <span class='record'>%s</span></p>" % (`level * 20`, data['lookup_of'], data['resolves_to'])
+        print "    <p style='padding-left:%spx'><span class='record'>%s</span> resolves to <span class='record'>%s</span>" % (`level * 20`, data['lookup_of'], data['resolves_to'])
     else:
-        print "    <p style='padding-left:%spx'><span class='record'>%s</span> does not resolve to anything!</p>" % (`level * 20`, data['lookup_of'])
+        print "    <p style='padding-left:%spx'><span class='record'>%s</span> does not resolve to anything!" % (`level * 20`, data['lookup_of'])
+
+    # display any problems associated with the record
+    for prob in data['problems']:
+        print "      <img src='icons/%s.png' />" % prob['icon']
+    print "    </p>"
 
     # recursively display subrecords